This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
Cherry-picks: Several bug fixes and react HMR #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 73cfccc)
* Pan mapbox map on query - Modify the backend to send back the bounds of the points to cluster - Clean up of mapbox component to derive lat, lon and zoom from the mercator that fitsbounds based on the bounds passed from the backend. This and the computation of clusters are now only done on initial load b/c we are not making queries to the backend on pan/zoom - A minor clean up of unused props and also making the visual properties panel open by default * Remove default latitude, longitude and zoom props which are unnecessary for computing the viewport now that it is driven by the bounds from the backend. * a few small tweaks (rename vars to be sneak case and avoid two extra hash lookups) (cherry picked from commit 6df720d)
(cherry picked from commit 1f6e8b3)
Since the recent PRs around webpack 4 and reloading, FAB pages have been flickering on load, where a themeless Superset is shown for a fraction of a second until the bootstrap theme gets loaded up. This addresses it by moving the theme JS to the head section of the html page. (cherry picked from commit 80faa8d)
* Remove jquery hack * change filter to find (cherry picked from commit 39ef77a)
…able (apache#5917) * fix percent metric display * add empty line * address string or number check (cherry picked from commit 19a3319)
kristw
changed the title
Codecov Report
@@ Coverage Diff @@
## airbnb-master #114 +/- ##
================================================
- Coverage 63.42% 63.3% -0.12%
================================================
Files 357 363 +6
Lines 22208 22245 +37
Branches 2502 2503 +1
================================================
- Hits 14085 14082 -3
- Misses 8111 8151 +40
Partials 12 12
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## airbnb-master #114 +/- ##
================================================
- Coverage 63.42% 63.3% -0.12%
================================================
Files 357 363 +6
Lines 22208 22245 +37
Branches 2502 2503 +1
================================================
- Hits 14085 14082 -3
- Misses 8111 8151 +40
Partials 12 12
Continue to review full report at Codecov.
|
michellethomas
approved these changes
Sep 18, 2018
michellethomas
pushed a commit
that referenced
this pull request
Dec 1, 2021
* feat: add mergeMargin() * fix: typings * refactor: address chris' comments
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick the following commit(s):
@john-bodley @conglei @graceguo-supercat @kristw @michellethomas @timifasubaa @williaster